added hyperlane adapter #17

degencodebeast · 2023-10-05T15:57:03Z

No description provided.

nambrot · 2023-10-20T13:41:19Z

src/hyperlane-adapter/HyperlaneReceiverAdapter.sol

+ * @title HyperlaneReceiverAdapter implementation.
+ * @notice `IBridgeReceiverAdapter` implementation that uses Hyperlane as the bridge.
+ */
+contract HyperlaneReceiverAdapter is


Can you rename this to indicate that this only supports v2

nambrot · 2023-10-20T13:42:51Z

src/hyperlane-adapter/HyperlaneReceiverAdapter.sol

+      address srcSender
+    ) = abi.decode(_body, (MessageLib.Message[], bytes32, uint256, address));
+
+    if (IMessageDispatcher(adapter) != senderAdapters[srcChainId]) {


IMO this should compare to the origin argument from the handle, no? Otherwise an origin chain sender from a different chain can falsely claim a different chain (even if it has to be permissioned as an adapter)

Did the comparison between the origin chain and the sender chain

nambrot · 2023-10-20T13:43:46Z

src/hyperlane-adapter/HyperlaneReceiverAdapter.sol

+    }
+    if (executedMessages[msgId]) {
+      revert MessageIdAlreadyExecuted(msgId);
+    } else {


This else is technically superflous, i like having all the revert conditions up front, and then do the state changes after

nambrot · 2023-10-20T13:44:10Z

src/hyperlane-adapter/HyperlaneSenderAdapter.sol

+import { IMessageExecutor } from "./interfaces/IMessageExecutor.sol";
+import "./libraries/MessageLib.sol";
+
+contract HyperlaneSenderAdapter is ISingleMessageDispatcher, IBatchedMessageDispatcher, Ownable {


Ditto about v2

nambrot · 2023-10-20T13:44:46Z

src/hyperlane-adapter/HyperlaneSenderAdapter.sol

+    bytes calldata /* data*/
+  ) external view returns (uint256) {
+    uint32 dstDomainId = _getDestinationDomain(toChainId);
+    // destination gasAmount is hardcoded to 500k similar to Wormhole implementation


Why not making this a configuration option in the constructor (and still default to 500k)

Made it a configurable option in the constructor

nambrot · 2023-10-20T13:46:01Z

src/hyperlane-adapter/HyperlaneSenderAdapter.sol

+    MessageLib.Message[] memory _messages = new MessageLib.Message[](1);
+    _messages[0] = MessageLib.Message({ to: _to, data: _data });
+
+    bytes memory payload = abi.encode(_messages, msgId, block.chainid, msg.sender);


We generally recommend having a library that does the encoding and decoding in one place;

created a separate library for encoding/decoding
Also used the library to do the encoding here instead

nambrot · 2023-10-20T13:46:17Z

src/hyperlane-adapter/HyperlaneSenderAdapter.sol

+      igp.payForGas{ value: msg.value }(
+        hyperlaneMsgId,
+        dstDomainId,
+        500000,


Move to constant/storage

Moved gasAmount to storage

nambrot · 2023-10-20T13:47:49Z

src/hyperlane-adapter/interfaces/ExecutorAware.sol

@@ -0,0 +1,109 @@
+// SPDX-License-Identifier: GPL-3.0


Why is this file here?

I am using a modified ExecutorAware contract, which allows me to add and remove multiple trusted executors as opposed to the poolTogether implementation which has just one executor that can only be initialized in the constructor, although now I have moved it to its own abstract folder

Is that necessary? It seems useful to be compliant with the default implementation? (its why we are doing this PR in the first place no?)

I have removed it

nambrot · 2023-10-20T13:48:22Z

src/hyperlane-adapter/interfaces/IBatchedMessageDispatcher.sol

@@ -0,0 +1,24 @@
+// SPDX-License-Identifier: GPL-3.0


All these files are already on main, no? You should import them from their canonical place

I have removed the unnecessary interfaces in the adapter apart from IBatchedMessageDispatcher and ISingleMessageDispatcher, because the ones I'm using for the hyperlane adapter have their dispatchMessage and dispatchMessageBatch functions marked as payable to faciliate the hyperlane dispatch function whereas the ones defined by poolTogether don't have their functions marked as payable

@asselstine Would be curious to hear how to handle this case? Should we modify the existing interface to make it payable?

degencodebeast · 2023-11-07T14:26:37Z

src/hyperlane-adapter/HyperlaneReceiverAdapterV2.sol


 /**
 * @title HyperlaneReceiverAdapter implementation.
 * @notice `IBridgeReceiverAdapter` implementation that uses Hyperlane as the bridge.
 */
-contract HyperlaneReceiverAdapter is
+contract HyperlaneReceiverAdapterV2 is


updated to V2

Should this be v3?

I have updated the adapter to use hyperlane V3 and added some unit tests as well

degencodebeast · 2023-11-07T14:34:12Z

src/hyperlane-adapter/HyperlaneReceiverAdapterV2.sol

-    ) = abi.decode(_body, (MessageLib.Message[], bytes32, uint256, address));
+    ) = EncodeDecodeUtil.decode(_body);
+
+    if (_origin != srcChainId) {


comparing the origin and sender chain

degencodebeast · 2023-11-07T14:38:22Z

src/hyperlane-adapter/HyperlaneReceiverAdapterV2.sol

+    if (_messages.length < 1) {
+      revert Errors.NoMessagesSent(srcChainId);
+    }
+
    if (executedMessages[msgId]) {
      revert MessageIdAlreadyExecuted(msgId);
    } else {


did all my revert conditions up front and did state changes after

degencodebeast · 2023-11-07T14:39:46Z

src/hyperlane-adapter/HyperlaneSenderAdapterV2.sol


-contract HyperlaneSenderAdapter is ISingleMessageDispatcher, IBatchedMessageDispatcher, Ownable {
+contract HyperlaneSenderAdapterV2 is ISingleMessageDispatcher, IBatchedMessageDispatcher, Ownable {


updated to V2

degencodebeast · 2023-11-07T14:43:53Z

src/hyperlane-adapter/HyperlaneSenderAdapterV2.sol

+
+    // See https://docs.hyperlane.xyz/docs/build-with-hyperlane/guides/paying-for-interchain-gas
+    // Set gasAmount to the default (500,000) if _gasAmount is 0
+    gasAmount = (_gasAmount == 0) ? 500000 : _gasAmount;


made gasAmount a configurable option in the constructor, it it isn't set (set to zero), it defaults to 500k

degencodebeast · 2023-11-07T14:45:50Z

src/hyperlane-adapter/libraries/EncodeDecodeUtil.sol

+ * @title EncodeDecodeUtil
+ * @notice Library to encode and decode payloads.
+ */
+library EncodeDecodeUtil {


created a separate library that does the encoding and decoding

degencodebeast · 2023-11-07T14:50:08Z

src/hyperlane-adapter/HyperlaneSenderAdapterV2.sol

@@ -112,7 +121,7 @@ contract HyperlaneSenderAdapter is ISingleMessageDispatcher, IBatchedMessageDisp
    MessageLib.Message[] memory _messages = new MessageLib.Message[](1);
    _messages[0] = MessageLib.Message({ to: _to, data: _data });

-    bytes memory payload = abi.encode(_messages, msgId, block.chainid, msg.sender);
+    bytes memory payload = EncodeDecodeUtil.encode(_messages, msgId, block.chainid, msg.sender);


Used the library I created for encoding/decoding to encode the messages with extra relevant data to generate a payload

degencodebeast · 2023-11-07T14:52:18Z

src/hyperlane-adapter/HyperlaneSenderAdapterV2.sol

-        //address(this)
-        msg.sender
-      )
+      igp.payForGas{ value: msg.value }(hyperlaneMsgId, dstDomainId, gasAmount, msg.sender)


Moved gas amount to storage as gas amount is now a state variable set in the constructor

asselstine · 2023-11-07T18:57:19Z

Hey- just seeing this. It's great to see another adapter!

avious00 · 2023-12-22T22:44:46Z

hey @asselstine is this good to merge? cc our CTO @nambrot

degencodebeast · 2024-01-23T18:45:07Z

Hey- just seeing this. It's great to see another adapter!

That's good to know, this project was a very good learning process for me as it's very impressive, and I got to learn a lot of from contributing to it.

degencodebeast added 3 commits October 5, 2023 15:39

added hyperlane adapter

2224532

refactored code + fixed bugs

41c447a

formatted code with prettier

787c755

degencodebeast mentioned this pull request Oct 5, 2023

EIP5164 Hyperlane Adapter hyperlane-xyz/hyperlane-monorepo#2180

Open

degencodebeast added 2 commits October 5, 2023 17:16

fixed bugs

8ac5460

adding overrides to dispatchMessage + handle fns

73a1fb9

nambrot reviewed Oct 20, 2023

View reviewed changes

degencodebeast added 2 commits November 7, 2023 00:43

fix: updated the code according to the review from nambrot

9bdd08b

added hyperlane dependency

7879ac5

degencodebeast commented Nov 7, 2023

View reviewed changes

updated to hyperlane V3

d778c87

degencodebeast added 4 commits January 23, 2024 19:53

fix: fixed bug in executeMessageBatch

17d4ebd

fix: fixed bug in executeMessageBatch

57b4df8

reverted to use openzeppelin's old ownable

fad1b72

updated ownable

9bf2e93

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added hyperlane adapter #17

added hyperlane adapter #17

degencodebeast commented Oct 5, 2023

nambrot Oct 20, 2023

degencodebeast Nov 7, 2023 •

edited

Loading

nambrot Oct 20, 2023

degencodebeast Nov 7, 2023 •

edited

Loading

nambrot Oct 20, 2023

degencodebeast Nov 7, 2023

nambrot Oct 20, 2023

degencodebeast Nov 7, 2023 •

edited

Loading

nambrot Oct 20, 2023

degencodebeast Nov 7, 2023 •

edited

Loading

nambrot Oct 20, 2023

degencodebeast Nov 7, 2023 •

edited

Loading

nambrot Oct 20, 2023

degencodebeast Nov 7, 2023

nambrot Oct 20, 2023

degencodebeast Nov 6, 2023 •

edited

Loading

nambrot Dec 27, 2023

degencodebeast Jan 23, 2024

nambrot Oct 20, 2023

degencodebeast Nov 7, 2023 •

edited

Loading

nambrot Dec 27, 2023

degencodebeast Nov 7, 2023 •

edited

Loading

nambrot Dec 27, 2023

degencodebeast Jan 23, 2024 •

edited

Loading

degencodebeast Nov 7, 2023

degencodebeast Nov 7, 2023

degencodebeast Nov 7, 2023

degencodebeast Nov 7, 2023

degencodebeast Nov 7, 2023

degencodebeast Nov 7, 2023

degencodebeast Nov 7, 2023

asselstine commented Nov 7, 2023

avious00 commented Dec 22, 2023

degencodebeast commented Jan 23, 2024


		contract HyperlaneSenderAdapter is ISingleMessageDispatcher, IBatchedMessageDispatcher, Ownable {
		contract HyperlaneSenderAdapterV2 is ISingleMessageDispatcher, IBatchedMessageDispatcher, Ownable {

added hyperlane adapter #17

Are you sure you want to change the base?

added hyperlane adapter #17

Conversation

degencodebeast commented Oct 5, 2023

Choose a reason for hiding this comment

degencodebeast Nov 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

degencodebeast Nov 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

degencodebeast Nov 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

degencodebeast Nov 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

degencodebeast Nov 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

degencodebeast Nov 6, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

degencodebeast Nov 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

degencodebeast Nov 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

degencodebeast Jan 23, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asselstine commented Nov 7, 2023

avious00 commented Dec 22, 2023

degencodebeast commented Jan 23, 2024

degencodebeast Nov 7, 2023 •

edited

Loading

degencodebeast Nov 7, 2023 •

edited

Loading

degencodebeast Nov 7, 2023 •

edited

Loading

degencodebeast Nov 7, 2023 •

edited

Loading

degencodebeast Nov 7, 2023 •

edited

Loading

degencodebeast Nov 6, 2023 •

edited

Loading

degencodebeast Nov 7, 2023 •

edited

Loading

degencodebeast Nov 7, 2023 •

edited

Loading

degencodebeast Jan 23, 2024 •

edited

Loading